Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching to prevent displaying the wrong variant #150

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Fix caching to prevent displaying the wrong variant #150

merged 6 commits into from
Apr 8, 2024

Conversation

mhkc
Copy link
Collaborator

@mhkc mhkc commented Apr 5, 2024

This PR fixes a bug that could cause the wrong to be displayed different regions were being displayed for the same case at the same time.

close #133

How to test:

  1. Use example variant in production Gens, http://cmdscout2.lund.skane.se/gens/24MD00143?region=6:32002301-32016300&variant=ee7d5522e87b70eb5bf525a6fce18104&genome_build=38&case_id=24MD00143&individual_id=24MD00143
  2. Try repoducing the bug by first opening the variant in the production version of Gens.
  3. Then change chromosome 6 to 8 in the url just after the page has loaded
  4. Verify that the chromosome number has not changed to 8 and the variant is still being displayed.
  5. Open the same variant in the dev version of Gens by replacing gens with gens_dev in the URL and repeat the steps above to reproduce the bug,

Expected outcome:
The new region and variant should be displayed.

Review:

  • code approved by

@mhkc mhkc linked an issue Apr 5, 2024 that may be closed by this pull request
Sometimes the wrong variant is being displayed in Gens using links from Scout. #133
Closed
@alkc alkc self-requested a review April 5, 2024 12:21
@alkc
Copy link

alkc commented Apr 5, 2024

The test checks out. Changing the chromosome in the url in gens_dev loads the correct chromosome position. This does not occur on the production instance.

alkc
alkc approved these changes Apr 5, 2024
View reviewed changes
gens/cache.py Outdated Show resolved Hide resolved
mhkc added 3 commits April 8, 2024 09:01
@mhkc
Merge branch 'master' into 133-sometimes-the-wrong-variant-is-being-d…
1031386 
…isplayed-in-gens-using-links-from-scout
@mhkc
use temp dir for flask caches
68fc3c3
@mhkc
Merge branch '133-sometimes-the-wrong-variant-is-being-displayed-in-g…
93ea741 
…ens-using-links-from-scout' of github.com:Clinical-Genomics-Lund/gens into 133-sometimes-the-wrong-variant-is-being-displayed-in-gens-using-links-from-scout
alkc
alkc approved these changes Apr 8, 2024
View reviewed changes
Copy link

@alkc alkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reran the tests and can confirm the bug is fixed in the dev instance.

@mhkc mhkc merged commit 55946b2 into master Apr 8, 2024
6 checks passed
@mhkc mhkc deleted the 133-sometimes-the-wrong-variant-is-being-displayed-in-gens-using-links-from-scout branch April 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkc alkc alkc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes the wrong variant is being displayed in Gens using links from Scout.
2 participants
@mhkc @alkc